Skip to content

TST: skip assert for mpl 3.1+ #26715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 8, 2019
Merged

TST: skip assert for mpl 3.1+ #26715

merged 4 commits into from
Jun 8, 2019

Conversation

TomAugspurger
Copy link
Contributor

@TomAugspurger TomAugspurger commented Jun 7, 2019 •
edited
Loading

Closes #26714
xref #26716

@TomAugspurger TomAugspurger added CI Continuous Integration Visualization plotting labels Jun 7, 2019
@TomAugspurger TomAugspurger added this to the 0.25.0 milestone Jun 7, 2019
@TomAugspurger TomAugspurger added Testing pandas testing functions or related to the test suite and removed CI Continuous Integration labels Jun 7, 2019
@TomAugspurger TomAugspurger mentioned this pull request Jun 7, 2019
Closed
@TomAugspurger
Copy link
Contributor Author

I'm going offline for at least a few hours, if anyone wants to keep pushing stuff here then feel free.

1b011d2 is worth keeping (assuming it works for our oldest MPL)

The other two commits are just debugging. In https://travis-ci.org/pandas-dev/pandas/jobs/542971521#L3018 we see that purest ---collect-only pandas is segfaulting.

@TomAugspurger
Copy link
Contributor Author

Something is going wrong when we import feather: https://travis-ci.org/pandas-dev/pandas/jobs/542977519#L3052

I'm going to remove it from the env for now, just to get the CI green again.

@TomAugspurger
Copy link
Contributor Author

Also, faulthandler / pytest-faulthandler is very useful.

@TomAugspurger
Copy link
Contributor Author

Seems like tests are collecting. Merging on green.

@TomAugspurger TomAugspurger mentioned this pull request Jun 8, 2019
Closed
@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@ef30df8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #26715   +/-   ##
=========================================
  Coverage          ?   91.77%           
=========================================
  Files             ?      174           
  Lines             ?    50703           
  Branches          ?        0           
=========================================
  Hits              ?    46534           
  Misses            ?     4169           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.37% <ø> (?)
#single 41.81% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef30df8...35d058e. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 8, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ef30df8). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #26715   +/-   ##
=========================================
  Coverage          ?   91.77%           
=========================================
  Files             ?      174           
  Lines             ?    50703           
  Branches          ?        0           
=========================================
  Hits              ?    46535           
  Misses            ?     4168           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.37% <ø> (?)
#single 41.83% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef30df8...460b8eb. Read the comment docs.

@TomAugspurger TomAugspurger merged commit 1cf1b96 into pandas-dev:master Jun 8, 2019
@TomAugspurger TomAugspurger deleted the 26714-ci branch June 8, 2019 04:22
@simonjayhawkins simonjayhawkins mentioned this pull request Jun 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

CI: matplotlib failures
1 participant
@TomAugspurger